feat: CMD-143 delete specific guide templates & styles #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2024
wesleyboar
changed the title
* fix: inaccurate text picture template name * fix: show value if old template is in use
* feat: support core-styles u-image-zoom * feat: support core-styles u-image-zoom via script * Revert "feat: support core-styles u-image-zoom via script" This reverts commit 2a15a75. * feat: support zoom_effect + no_link_to_image * refactor: only load css once from multiple tries * refactor: extract link & figure start to templates * refactor: rebuild zoom templates to strip classes * feat: template tag `strip_class_attribute` * fix: strip_class_attribute munges data-class test * fix: template name/path typo * fix: all picture template bugs i think * docs: add help_text to Picture template field * feat: overwrite bs4 picture plugin validation * fix: strip_class_attr… regex munges `data-class` * test: highlight unsupported figure image zoom * fix: u-image-zoom-- class not added * fix: sometimes span missing & class in wrong spot * fix: core-styles zoom bug * enhance: clearer debuging ui * refactor: template logic → custom view context * Revert "refactor: template logic → custom view context" This reverts commit a123568.
* feat: support core-styles u-image-zoom * feat: support core-styles u-image-zoom via script * Revert "feat: support core-styles u-image-zoom via script" This reverts commit 2a15a75. * feat: support zoom_effect + no_link_to_image * refactor: only load css once from multiple tries * refactor: extract link & figure start to templates * refactor: rebuild zoom templates to strip classes * feat: template tag `strip_class_attribute` * fix: strip_class_attribute munges data-class test * fix: template name/path typo * fix: all picture template bugs i think * docs: add help_text to Picture template field * feat: overwrite bs4 picture plugin validation * fix: strip_class_attr… regex munges `data-class` * test: highlight unsupported figure image zoom * fix: u-image-zoom-- class not added * fix: sometimes span missing & class in wrong spot * fix: core-styles zoom bug * enhance: clearer debuging ui * refactor: template logic → custom view context * Revert "refactor: template logic → custom view context" This reverts commit a123568. * refactor: template logic → custom view context * fix: bad/old path to zoom asset * refactor: move css snippet to stylehseet * refactor: rename test stylesheet * fix: test stylesheet too specific * fix: a lot, and simplify * refactor!: revert template names * fix: final bugs * chore: remove excess new line * refactor: simplify templates and update comments
* deps: core-styles v2.46.1 * refactor: u-image-zoom via core-styles
* fix: space under span.u-image-zoom img * deps: core-styles v2.46.2
* feat: snippet to redirect external article * fix: load Core-CMS script not tup-ui script
* **adds** —
```css
.align-center:not(img):has(img){
width:fit-content;
}
```
— to `site.css` (outdated)
* **deletes** warnings about bug
* **updates** translations
* deps: core-styles v2.48 * deps: core-styles v2.50 for core-styles.bootstrap * fix: bootstrap4.css, not bootstrap.css * feat: do not deprecate Link / Button plugin * fix: .btn with .icon (FOR CORE-STYLES) * fix: .icon not working via djangocms-bootstrap4 django-cms/djangocms-bootstrap4#124 * fix: load REAL Core-Styles v2.50 (TEMP FIX) * feat: NO preview for Bootstrap Link/Pluign render Because: 1. Using Core-Styles to skin it requires @layer's. - Cuz Core-Styles selectors are often less specific than Bootstrap. 2. Using @layer's requires the same for DJango CMS and Django. 3. Using @layer's for Django CMS nad Django is not worht the trouble. * deps: core-styles v2.50.1 * feat: remove link_outline and link_block options * feat: remove unsupported bootstrap "colors" might revisit this for alerta * feat: remove unsupported bootstrap button "size" * feat: rename Context to Type
So add new class on wrap, and use it to support box model.
* fix: social media icons need not default giant * fix: prevent underline of extra space on hover by removing extra space
* feat: logo icons inherit color * feat: organization logos inherit color * feat: core logo inherit color * feat: logos inherit size * fix: ending `<p>` tag * feat: Icon svg inherit size * fix: no empty underlined space on hover * fix: tacc formal logo fill wrong * fix: bluesky logo duplicate code * feat: color icons * fix: bust cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview / Changes
Status
Related
Testing
Warning
Untested
Verify zero Core-CMS websites use these specific templates by changing all pages that use "Guide: …" to use "Guide" (or "Inherit from …").
UI
Skipped.