[#12588] Improve test code coverage of visibility message pipes#13573
Closed
AlanRQiu wants to merge 1 commit intoTEAMMATES:masterfrom
Closed
[#12588] Improve test code coverage of visibility message pipes#13573AlanRQiu wants to merge 1 commit intoTEAMMATES:masterfrom
AlanRQiu wants to merge 1 commit intoTEAMMATES:masterfrom
Conversation
|
Hi @AlanRQiu, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
Member
|
Thank you for your interest in contributing, please ensure all tests pass before we go ahead and review this PR. |
Member
|
Closing due to inactivity to keep things tidy and so others can work on it. If you’d like to continue working on it, feel free to reopen the PR or create a new one anytime. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12588
Description
This PR improves the test coverage for the VisibilityCapabilityPipe and VisibilityEntityNamePipe.
Changes
Added unit tests to visibility-capability.pipe.spec.ts covering all logical branches.
Added unit tests to visibility-entity-name.pipe.spec.ts covering entity pluralization and default "unknown" cases.
Verification Results
All tests passed locally using npm test.