Skip to content

[#12588] Improve test code coverage of visibility message pipes#13573

Closed
AlanRQiu wants to merge 1 commit intoTEAMMATES:masterfrom
AlanRQiu:12588-visibility-messages-tests
Closed

[#12588] Improve test code coverage of visibility message pipes#13573
AlanRQiu wants to merge 1 commit intoTEAMMATES:masterfrom
AlanRQiu:12588-visibility-messages-tests

Conversation

@AlanRQiu
Copy link
Copy Markdown

@AlanRQiu AlanRQiu commented Mar 7, 2026

Part of #12588

Description
This PR improves the test coverage for the VisibilityCapabilityPipe and VisibilityEntityNamePipe.

Changes
Added unit tests to visibility-capability.pipe.spec.ts covering all logical branches.
Added unit tests to visibility-entity-name.pipe.spec.ts covering entity pluralization and default "unknown" cases.

Verification Results
All tests passed locally using npm test.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 7, 2026

Hi @AlanRQiu, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

@samuelfangjw
Copy link
Copy Markdown
Member

Thank you for your interest in contributing, please ensure all tests pass before we go ahead and review this PR.

@samuelfangjw
Copy link
Copy Markdown
Member

Closing due to inactivity to keep things tidy and so others can work on it. If you’d like to continue working on it, feel free to reopen the PR or create a new one anytime. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants