Use input registry to fetch provider spec#1
Draft
etinquis wants to merge 1 commit into
Draft
Conversation
Author
|
The provider that will reproduce the issues is etinquis/mssql 0.1.0, which is not in the opentofu registry (https://registry.terraform.io/providers/etinquis/mssql/latest). |
…rmalize) for final providers.tf.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registry.opentofu.orgwas previously hardcoded in spec fetch, causing errors if the provider is not in both the input registry and opentofu's (not to mention potential version differences between the two).On top of this, something in the packing process is placing the binaries from a non-opentofu-registry provider into the registry.opentofu.org directory under terraform-providers, causing errors trying to find the provider again.
e.g.:
I didn't make it deep enough in the source to determine where the second problem is coming from, I've just short-circuited it by removing the special casing for registry provided vs not provided when removing the registry part (meaning, in short, that all providers are expected to be 'normalized' to appear to be pulled from registry.opentofu.org in the consolidated package, matching the observed current behavior). I don't stand by this fix, you will know better how to fix it such that both registries are reflected in the output, should you want to do that.