Skip to content

most oddDecl elements must be descendant of <schemaSpec> or <specGrp>#2855

Open
sydb wants to merge 7 commits into
devfrom
issue_2306
Open

most oddDecl elements must be descendant of <schemaSpec> or <specGrp>#2855
sydb wants to merge 7 commits into
devfrom
issue_2306

Conversation

@sydb

@sydb sydb commented Jan 4, 2026

Copy link
Copy Markdown
Member

Address #2306 by:

  • Issue a DEPRECATION WARNING if a <classSpec>, <constraintSpec>, <dataSpec>, <elementSpec>, <macroSpec>, <outputRendition>, or <specGrpRef> is not inside a <schemaSpec>, a <specGrp>, or a <egXML> (due to testing-swaps-namespace thing).
  • Change Guidelines so that all of our such elements are in fact inside <specGrp>
  • Add a test (<elementSpec>-inside-<head>)

In 9–10 months time the deprecation warning should become an error.

Note: This is currently a DRAFT PR, as I have not yet added a note to Appendix G (deprecations). Hope to get to that tonight, but figure the rest can be looked at without that.

@sydb sydb marked this pull request as ready for review January 7, 2026 03:01
@martindholmes

Copy link
Copy Markdown
Contributor

With @sydb and @HelenaSabel : We tested this and determined that there are 981 cases that violate these constraints within p5subset.xml (spec elements are children of divs there). Therefore we chose to postpone this merge until after the February release, so that we can also add wrapping specGrps to make p5subset.xml valid (for which another ticket already exists), and check that there's no fallout from that change in the Stylesheets ODD processing.

@martindholmes

Copy link
Copy Markdown
Contributor

Coming back to this: it seems that there are a lot of irrelevant changes to the way the XInclude namespace is declared and used in the PR, which is a bit confusing. @sydb Was there any intention here, or is this just meaningless fallout from the use of an XML parser/serializer that does things differently? Could we remove those changes from the future PR to make it easier to evaluate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants