Update prose on <gloss> to mention att.placement membership#2902
Update prose on <gloss> to mention att.placement membership#2902trishaoconnor wants to merge 3 commits into
<gloss> to mention att.placement membership#2902Conversation
sydb
left a comment
sydb
left a comment
There was a problem hiding this comment.
Only major thing that needs to be fixed before merge is the typo on line 1229.
| <att>place</att> attribute for indicating where the | ||
| gloss is with respect to the text. | ||
| <specList> | ||
| <specDesc key="att.placement" atts="place"/> |
There was a problem hiding this comment.
I am hesitant about the addition of @atts in this line. While I am not really against it, seems to me the only thing it achieves is that if we ever add another attribute to att.placement (e.g. @subplace :-) it would not show up here. That might be a good thing, but I think it more likely to be a bad thing.
There was a problem hiding this comment.
Thank you for bringing this to my attention @sydb, I have removed @atts from line 1056 now.
| <specDesc key="rt"/> | ||
| </specList> | ||
| The <gi>rt</gi> element is a member of <ident type="class">att.placement</ident>, and thus the | ||
| C The <gi>rt</gi> element is a member of <ident type="class">att.placement</ident>, and thus the |
There was a problem hiding this comment.
Looks like just a boo-boo. The leading ‘C’ should be deleted.
There was a problem hiding this comment.
Thank you @sydb for catching this embarrassing typo.
3 participants
This PR addresses issue #2892 by updating the Terms and Glosses section of the Guidelines to state that the
<gloss>element claims membership ofatt.placement. I also highlighted the suggested values which might be most relevant for encoding glosses that occur in the margins of a text as well as above or below a line of text.