Repository navigation
Keep waiting letters out of dead player inventories - #40
Merged
Merged
Conversation
github-actions
Bot
added
the
size:XS
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 27 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The online mail retry could deliver pending letters while their recipient was on the death screen. An ordinary death can leave the character session active and the inventory empty; respawn can then discard the delivered letter after its saved queue entry has already been removed.
Reject delivery capacity while the recipient is dead. Incoming letters and both pending queues therefore keep waiting, and the normal timer resumes delivery after respawn. This covers ordinary mail, unsent letters, and estate returns without changing persistence or configuration.
Documentation: TF-Minecraft/Docs#294
Validation: all three new regression tests fail on v1.3.1. Java 21
tfmc-mvn -o -B --no-transfer-progress clean verifypasses 256 tests and the existing 100% production line-coverage gate. Muse review round 2 found no actionable findings, verifying both the correction and the full inventory-delivery diff.