Skip to content

config: bring the default configs in line with Main (hot food 30 min, warm until 2h30) - #103

Merged
XxFran10xX merged 2 commits into
mainfrom
config/hot-food-warmth-timing
Oct 31, 2026
Merged

XxFran10xX merged 2 commits into
mainfrom
config/hot-food-warmth-timing

Conversation

@XxFran10xX

@XxFran10xX XxFran10xX commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Cooking never overwrites existing config files, so Main's live configs had values tuned in place that the defaults never got. This PR copies every value Main runs into src/main/resources, keeping the repo's comments and the newer husbandry keys (enabled, restore-lost-animals) that Main gets from the code defaults. Parsed as YAML, all six differing files now match Main's (crafting-stations.yml only differed in comments, so it is unchanged).

Hot food timing (live since 2026-10-31 02:14 UTC on Main and Tutorial):

  • types.yml: every food type gets age: warmth: 450 (one warmth age unit = 7.5 minutes).
  • tags.yml: the Warm step starts at age 4 instead of 10.
  • The jar ends warmth at age 20, so food is Hot for 30 minutes and Warm until 2h30. Then the warmth tag goes; the food stays.

Other values Main already runs:

  • types.yml: food values and freshness multipliers on 21 types; frying pan options for three vegetable types.
  • tags.yml: Rotten after 1.25 days (was 3); soup thickness steps 20/40/60/80 (was 300/900/1800/3600); dough rising after 20 seconds and risen after 45 (was 5 and 15 minutes), with the comment updated to match.
  • config.yml: respawn-food 200 (was 80), drain-interval 240 (was 120).
  • husbandry.yml: profession: forager (was farming); speed care-pct 0.30 (was 0.20); horses max-health 27, max-speed 0.27, max-jump 0.8 (were 20 / 0.2025 / 0.6).
  • crops.yml: allowed-cover lists leaves, logs, fences, lanterns, chains, banners, hanging signs and similar blocks (was empty).

Documentation impact

Contract

  • Affected behavior: default configs for new installs only. Existing servers keep their own files; Main and Tutorial already run these values.
  • Tests run (mvn test, or why not): mvn -B verify locally: 1313 tests, 2 failures, both from the Windows locale printing decimal commas (HusbandryInspectionCoverageTest, RuntimeUtilitiesCoverageTest), unrelated. CI runs on Linux.
  • Player wiki (ProvinceSystem /wiki/cooking or related pages): no change. The wiki already describes Main (soup thickens over 80 seconds; leaves, logs and fences count as open sky); warmth and other durations are hidden numbers.

Notes

  • Values only; no code change.

🤖 Generated with Claude Code

Every food type now ages warmth 450 times slower (age.warmth 450), and
the Warm step starts at age 4. The jar ends warmth at age 20, so food is
Hot for 30 minutes and Warm until 2h30. Main and Tutorial already run
these values; this brings the default configs in line with them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 53 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7f27edc3-2346-4381-8daa-7b803f3f3864
Commits

Reviewing files that changed from the base of the PR and between e7beaa1 and b3556da.

Files selected for processing: 5
  • src/main/resources/config.yml
  • src/main/resources/crops.yml
  • src/main/resources/husbandry.yml
  • src/main/resources/tags.yml
  • src/main/resources/types.yml

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f2ddec45-65af-4549-bee4-ee6b93a2bf88
Commits

Reviewing files that changed from the base of the PR and between e15e662 and e7beaa1.

Files selected for processing: 2
  • src/main/resources/tags.yml
  • src/main/resources/types.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Summary

Summary by CodeRabbit

  • New Features
    • Food items across a wider range of categories now track warmth as they age, alongside their existing freshness and rising values.
    • Warmth expires at age 20, with each age unit representing 7.5 minutes (2 hours 30 minutes in total).
  • Updates
    • The warm value has decreased from 10 to 4.

Food type configurations now include warmth ageing values. The warm tag value decreases from 10 to 4, and its documentation describes the duration represented by warmth age 450 and when warmth expires.

Changes: Food warmth settings

Layer / File(s) Summary
Configure food warmth ages
src/main/resources/types.yml
Added age.warmth: 450 to configured food types. The file comments describe warmth ageing.
Update warm tag value and duration
src/main/resources/tags.yml
Changed the warm value from 10 to 4. The documentation states that warmth age 450 corresponds to 7.5 minutes per age unit and that warmth expires at age 20 (2 hours 30 minutes).

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: carolinebondhus

Merge Risk: Minimal · previous review e7bea

The warmth timing defaults are internally consistent and no concrete merge-blocking behavior is identified.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@XxFran10xX

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@github-actions github-actions Bot added the size:M 30-99 effective changed lines (tests excluded in mixed PRs). label Oct 31, 2026
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 31, 2026
Main's Cooking config files had values tuned live that the defaults
never got. Take them all, keeping the repo's comments and the newer
husbandry keys (enabled, restore-lost-animals) that Main gets from the
code defaults:

- types.yml: food values and freshness multipliers on 21 types, and
  frying pan options for three vegetable types.
- tags.yml: Rotten after 1.25 days, soup thickness steps at
  20/40/60/80, dough rising after 20 seconds and risen after 45.
- config.yml: respawn food 200, nutrition drain every 240 seconds.
- husbandry.yml: profession forager, speed care share 0.30, horses up
  to 27 health, 0.27 speed and 0.8 jump.
- crops.yml: leaves, logs, fences, lanterns and similar blocks count
  as open sky over crops.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@XxFran10xX XxFran10xX changed the title config: keep cooked food hot for 30 minutes and warm until 2h30 config: bring the default configs in line with Main (hot food 30 min, warm until 2h30) Oct 31, 2026
@github-actions github-actions Bot added size:L 100-499 effective changed lines (tests excluded in mixed PRs). and removed size:M 30-99 effective changed lines (tests excluded in mixed PRs). labels Oct 31, 2026
@XxFran10xX

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@XxFran10xX
XxFran10xX merged commit 523fbfe into main Oct 31, 2026
3 checks passed
@XxFran10xX
XxFran10xX deleted the config/hot-food-warmth-timing branch October 31, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant