Repository navigation
feat: give sandwiches and pizzas bonuses from their layers - #105
Merged
Merged
Conversation
Sandwiches and pizzas earn tags from their layers, like a soup's Seasoned or Thick: Hearty or Loaded by filling count, Buttered, Well-Rounded and Flavourful for sandwiches; Saucy, Extra Cheesy, Seasoned, Rounded or Aromatic and Sweet and Savoury for pizzas. The rules are a bonuses section in sandwiches.yml and pizzas.yml, and the multipliers are tags.yml tracks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sandwiches and pizzas now earn tags from their layers, the way a soup earns Seasoned, Rounded or Thick. Each tag is a
tags.ymltrack, so its food and nutrition multipliers apply to the dish and show in its lore.bonusessection insandwiches.ymlandpizzas.yml, read byDishBonus. Each bonus names a track and what earns it:count: fillings(fillings or toppings, not bread, dough or sauce) orcount: seasonings(different salts and peppers), withstepsgiving the step reached at each countlayers(every one of these layer ids, each at leastmintimes) andany-ofaddons: rounded | aromatic(a chopped garnish and a spice, or two of one kind, counted by origin)valuable: true(a foodtypes.ymlmarks valuable)tags.ymltracks:dish_size(hearty, loaded),buttered,well_rounded,saucy,extra_cheesy,sweet_and_savoury. Seasoning, Rounded, Aromatic and Flavourful reuse the soup's tracks.sandwiches.yml's Well-Rounded listscatsupandmustardas spreads too. Those layers come with the condiments (feat: make vinegar, sap, catsup, mustard, maple syrup and olive oil #100); until then they simply match nothing.Documentation impact
sandwiches.ymldocuments the bonus keys, and the README mentions the bonuses.Contract
bonusessection, nothing changes.mvn -o -B clean verify. 1321 tests pass and line coverage is still 100%. The newDishBonusTestcovers loading and every rule.cooking-DEV-dish-bonuses.jar) and starts cleanly. The bonuses aren't checked in game yet.tags.yml,sandwiches.ymlandpizzas.ymlhave the new tracks and bonuses. Main needs them added when this is released.ProvinceSystem/wiki/cookingor related pages): no change yet.🤖 Generated with Claude Code