Skip to content

fix: keep pizza toppings apart, sauce on the dough and dishes to their own ageing - #106

Merged
JustinasLa merged 3 commits into
mainfrom
fix/pizza-layers
Oct 31, 2026
Merged

JustinasLa merged 3 commits into
mainfrom
fix/pizza-layers

Conversation

@JustinasLa

@JustinasLa JustinasLa commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Toppings keep apart. Each topping first looks for a model laid out for its place among the toppings (_t1 for the second, up to _t5 for the sixth), so models can give each place its own spots and toppings never lie in each other, whatever they are. It then falls back to the plain model. SandwichLayer.model takes those suffixes; PizzaPeel passes them.
  • Sauce on the dough. The dough is 0.5 thick (pizzas.yml base thickness), so the sauce and toppings lie on its flat middle inside the raised crust.
  • Dishes age only on their own tracks. A pizza slice used to take its cheese's ripening track as well as its freshness: both showed "Fresh" and both raised its nutrition. CompositionFreshnessApplier.keepOwnAgeing now keeps only the ageing tracks the dish's own type ages on, for pizzas and sandwiches.

Documentation impact

Contract

  • Affected behaviour:
    • How toppings and sauce lie on a pizza peel.
    • Which ageing tracks a finished pizza slice or sandwich keeps.
  • Tests run: mvn -o -B clean verify. 1322 tests pass and line coverage is still 100%. PizzaCoverageTest and QualityRuntimeCoverageTest cover the changes.
  • Tested on Dev: on Dev since 2026-10-29. Topping layouts were checked offline for clipping (every layer pair in the pack); neither change is confirmed in game.
  • Player wiki (ProvinceSystem /wiki/cooking or related pages): no change.

🤖 Generated with Claude Code

JustinasLa and others added 2 commits October 29, 2026 19:14
…r own ageing

Each topping looks for a model laid out for its place among the toppings
(_t1 for the second), so models can give each place its own spots and
toppings never lie in each other, whatever they are. The dough is 0.5
thick, so the sauce and toppings lie on its flat middle inside the crust.

Pizzas and sandwiches keep only the ageing tracks their own type ages on:
a pizza slice took its cheese's ripening as well as its freshness, both
"Fresh" and both raising its nutrition.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cb2c72a7-8d56-4666-ad50-c31e70dfc550
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the size:M 30-99 effective changed lines (tests excluded in mixed PRs). label Oct 31, 2026
@JustinasLa
JustinasLa merged commit 222373c into main Oct 31, 2026
3 checks passed
@JustinasLa
JustinasLa deleted the fix/pizza-layers branch October 31, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant