Repository navigation
Show earnings and tax in one chat line - #41
Merged
Merged
Conversation
A taxed payment showed "+8.75d" and "(1.25 in tax)" on separate lines, which read as if the tax was taken again. Send one line instead, "+8.75d (after 1.25d tax)", from a public MoneyManager.tellEarned that SimpleFactions can share. money.tax stays for Games' wager tax. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
size:S
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 3
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Reviewed by GPT-6.1-Sol (xhigh): no findings, VERDICT: OK. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A taxed payment showed two chat lines, "+8.75d" and "(1.25 in tax)". Players could read that as 1.25 being taken again from the 8.75. The 8.75 is what reached their account, and the tax was already withheld.
Taxed payments now show one line: +8.75d (after 1.25d tax), with the tax part in grey. Untaxed payments still show "+8.75d". The new key is
money.earned-taxed. Livemessages.ymlfiles pick it up from the bundled defaults, so no server edit is needed.MoneyManager.tellEarned(CommandSender, netCents, taxCents)is public so SimpleFactions' gold bar bank deposits can send the same line (SimpleFactions PR to follow, pinned to this release).money.taxis unchanged because Games still uses it for wager tax.Tests: the pickup tests now expect the single taxed line and no separate
money.taxline.mvn clean verifypasses.🤖 Generated with Claude Code