Skip to content

fix: correct command tab completion - #38

Merged
ryanbarlow97 merged 1 commit into
mainfrom
fix/command-tab-completion-20261015
Oct 15, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
fix/command-tab-completion-20261015

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Correct command suggestions to match the arguments accepted by DrinkBuilder, including the current prefix and applicable permission or sender context.

  • DRINK-01: pack completion includes pull and reapply together for an empty token and filters both against partial prefixes.

Validation: tfmc-mvn -o -B --no-transfer-progress clean verify passed (175 tests, zero failures, errors or skips), including command-completion regressions. git diff --check passed.

Documentation: TF-Minecraft/Docs#266.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c71c6764-f041-4748-b289-ce57326784d5
📥 Commits

Reviewing files that changed from the base of the PR and between 87a017d and f28f53b.

📒 Files selected for processing: 2
  • src/main/java/net/tfminecraft/drinkbuilder/managers/CommandManager.java
  • src/test/java/net/tfminecraft/drinkbuilder/managers/CommandManagerTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Tab completion for the pack command now shows both pull and reapply when no input prefix is provided, and filters suggestions as you type.

The pack subcommand now filters suggestions from a combined pull and reapply list. The tab-completion test expects both suggestions when the input prefix is empty.

Changes: Pack tab completion

Layer / File(s) Summary
Filter pack suggestions
src/main/java/net/tfminecraft/drinkbuilder/managers/CommandManager.java, src/test/java/net/tfminecraft/drinkbuilder/managers/CommandManagerTest.java
Suggestions come from the combined pull and reapply list and are filtered by the input prefix. The test expects both suggestions for an empty prefix.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to f28f5

Authorized users receive the valid pack actions, while completion filters suggestions by prefix. No actionable merge risk remains.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:XS 0-9 effective changed lines (tests excluded in mixed PRs). label Oct 15, 2026
@ryanbarlow97
ryanbarlow97 marked this pull request as ready for review October 15, 2026 18:44
@ryanbarlow97
ryanbarlow97 merged commit d6342d8 into main Oct 15, 2026
4 checks passed
@ryanbarlow97
ryanbarlow97 deleted the fix/command-tab-completion-20261015 branch October 15, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant