You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Correct command suggestions to match the arguments accepted by InteractibleFurniture, including the current prefix and applicable permission or sender context.
INTERACTIBLEFURNITURE-01: Console completion offers reload only when permitted; nested and debug actions and descendants are player-only.
Validation: tfmc-mvn -o -B --no-transfer-progress clean verify passed (303 tests, zero failures, errors or skips), including command-completion regressions. git diff --check passed.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
Bug Fixes
Restricted nested and debug command suggestions to players with the relevant permissions.
Console senders can still receive permitted reload suggestions but no longer receive player-only subcommand suggestions.
Tests
Added coverage for console tab-completion behaviour with and without reload permission.
Tab completion now restricts nested and debug suggestions based on sender type and permissions. A console test checks reload suggestions and confirms that nested and debug suggestions are not returned.
Changes: Tab completion
Layer / File(s)
Summary
Filter suggestions by sender and permission src/main/java/net/tfminecraft/interactiblefurniture/command/IfCommand.java, src/test/java/net/tfminecraft/interactiblefurniture/command/IfCommandCoverageTest.java
nested suggestions require a player with reload permission. debug suggestions require a player with debug permission. Non-player senders receive no suggestions for subsequent arguments. Tests check console suggestions for reload, nested, and debug.
Suggestions follow the command’s sender and permission rules, and tests cover representative prefixes. No concrete merge-blocking behavior is established.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 effective changed lines (tests excluded in mixed PRs).
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct command suggestions to match the arguments accepted by InteractibleFurniture, including the current prefix and applicable permission or sender context.
INTERACTIBLEFURNITURE-01: Console completion offers reload only when permitted; nested and debug actions and descendants are player-only.Validation:
tfmc-mvn -o -B --no-transfer-progress clean verifypassed (303 tests, zero failures, errors or skips), including command-completion regressions.git diff --checkpassed.Documentation: TF-Minecraft/Docs#266.