Repository navigation
Add hidden class unlocks and a knockout move for dragged bodies - #138
Draft
XxFran10xX wants to merge 6 commits into
Draft
XxFran10xX wants to merge 6 commits into
XxFran10xX wants to merge 6 commits into
Conversation
Other plugins can unlock a hidden MMOCore class (options.display: false) for one character through ClassUnlocks. Unlocked classes are saved in the character file under "unlocked-classes" and appear in the class picker after the displayed base classes, priced like any other class change. Staff can use /rpcharacter admin unlockclass|lockclass <player> <classId>. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
moveDowned now teleports first and stores the new freeze spot only on success, refuses a location without a world, and the freeze compares the world too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…points Hidden classes another plugin assigns (Magic's wild magic classes) are no longer offered in the class picker. ClassUnlocks.assign switches the character into the class for free, and while it plays an assigned class /class (and the class stage edit) refuses any change until staff release it. Staff commands are now assignclass and releaseclass (unlockclass and lockclass still work). ClassSkillPoints gives a class its own per-character skill-point pool, so the character's shared points never reach it; staff skill-point commands on such a class change its own pool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Traits can be marked hidden: the creation catalog and the character roster sent to the website leave them out, while the game still shows them. Manaless (injury-traits.yml, hidden) is the devotee's mark from Magic's secret blood path: -2 to every attribute, and Magic takes away all mana while a character bears it. Nothing else gives it: it is not a progression target and has no prosthetic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The character menu's trait summary and its full trait list now leave out hidden traits (such as Manaless) when anyone but the character's own player opens them. The owner's own views are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two additions that Magic's hidden blood path needs:
ClassUnlocks).unlock,lock,unlockedandisUnlockedfor the active character.unlocked-classes.display: false) at normal pricing./rpcharacter admin unlockclass|lockclass <player> <classId>.PvpKnockoutManager.moveDowned(Player, Location). Moves a knocked-out player and keeps the knockout freeze at the new spot, so a plugin can drag a body.Tests
main.moveDownedfindings (a refused teleport, the world in the freeze, a null world) are fixed with tests.Used by TF-Minecraft/Magic
feat/bloodmagic-progression, by reflection.🤖 Generated with Claude Code