Skip to content

Clarify rarity-based recycling of crafted artifacts - #39

Merged
XxFran10xX merged 1 commit into
mainfrom
followup/sealed-artifact-alignment
Oct 21, 2026
Merged

XxFran10xX merged 1 commit into
mainfrom
followup/sealed-artifact-alignment

Conversation

@XxFran10xX

@XxFran10xX XxFran10xX commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sealed artifacts can now be crafted, so explain that node artifacts and artifacts opened from seals recycle by rarity rather than crafting inputs. Update both the bundled config comments and provider Javadoc, and remove a mine-yield comparison that depends on source weights and node configuration.

This changes comments only; recycling amounts, eligibility and behavior are unchanged.

Validation: all 132 tests and Maven verification pass in Linux CI. All 10 focused Windows artifact/loader tests pass; the full Windows suite encounters file-persistence AccessDenied errors. Dev passed a 54-check integration smoke test including normal and husk returns for all four artifact rarities and rejection of all five unopened sealed items by the complete provider chain. Self-review is clean within three rounds.

Documentation: TF-Minecraft/Docs#312

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ed902bb3-4f11-4b6c-8ad7-13a2433c2b79
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:S 10-29 effective changed lines (tests excluded in mixed PRs). label Oct 21, 2026
@XxFran10xX
XxFran10xX marked this pull request as ready for review October 21, 2026 17:06
@XxFran10xX
XxFran10xX merged commit 6513443 into main Oct 21, 2026
4 checks passed
@XxFran10xX
XxFran10xX deleted the followup/sealed-artifact-alignment branch October 21, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant