Repository navigation
Clarify rarity-based recycling of crafted artifacts - #39
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
XxFran10xX
marked this pull request as ready for review
October 21, 2026 17:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sealed artifacts can now be crafted, so explain that node artifacts and artifacts opened from seals recycle by rarity rather than crafting inputs. Update both the bundled config comments and provider Javadoc, and remove a mine-yield comparison that depends on source weights and node configuration.
This changes comments only; recycling amounts, eligibility and behavior are unchanged.
Validation: all 132 tests and Maven verification pass in Linux CI. All 10 focused Windows artifact/loader tests pass; the full Windows suite encounters file-persistence AccessDenied errors. Dev passed a 54-check integration smoke test including normal and husk returns for all four artifact rarities and rejection of all five unopened sealed items by the complete provider chain. Self-review is clean within three rounds.
Documentation: TF-Minecraft/Docs#312