Repository navigation
fix: keep players in the faction when they leave or are kicked from a guild - #204
Merged
Merged
Conversation
… guild /guild leave and /guild kick removed the player from their guild, and since faction membership is the members of its guilds, from the whole faction too. They now return the player to the faction's main guild. In the main guild, /guild leave points to /faction leave, and /faction leave tells guild members to leave their guild first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving or being kicked from a guild no longer removes you from the faction.
Faction membership is the members of all its guilds, so
/guild leaveand/guild kickused to take the player out of the whole faction. fran confirmed that's not intended: you should stay in the faction, in its main guild./guild leave(in a guild other than the main one) moves you back to the faction's main guild and says so./guild kickdoes the same for the kicked member, and tells them they're back in the main guild. A guild leader can no longer expel someone from the faction; that stays with/faction kick./guild leavein the main guild now points to/faction leaveinstead of silently leaving the faction./faction leavefor a guild member now says: "Use /guild leave first, then /faction leave".Tests:
GuildKickCommandTestandCommandManagerCoverageTestupdated (kick and leave verifyaddMemberon the faction; new main-guild case). Locally both suites pass apart from two forced-withdrawal tests inCommandManagerCoverageTestthat also fail on unmodifiedmainon this Windows PC.No version bump or release in this PR.
🤖 Generated with Claude Code