Repository navigation
fix: label battle-hour votes in CET/EST, not UTC - #205
Conversation
Battle hours are Europe/Paris schedule hours, but the chat reply said "20:00 UTC". It now uses the same CET / EST label as the vote items. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Format battle-hour vote confirmations src/main/java/net/tfminecraft/simplefactions/managers/inventory/CampaignView.java, src/test/java/net/tfminecraft/simplefactions/managers/inventory/CampaignMenusCoverageTest.java |
Added and removed vote messages now use the formatted battle-hour label and hex formatting. The test checks that the label starts with 20:00 CET and verifies both confirmation messages. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: ryanbarlow97
Merge Risk: 
c8f68
-
The PR correctly aligns vote confirmations with the campaign’s CET/EST time labels.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
github-actions
Bot
added
the
size:XS
The CET / EST label dims the New York date with a hex colour when it falls on the previous day; run the reply through formatHex like the vote items so chat never shows the raw code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@coderabbitai review |
✅ Action performed
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Picking a battle hour in the campaign menu replied "Added 21:00 UTC to your availability". Battle hours are schedule hours in Europe/Paris (
BattleWindowService.SCHEDULE_ZONE, and the comment inConfigLoader), so "21:00 UTC" was an hour or two off. The hour items in the same menu already say "21:00 CET / 15:00 EST" throughCampaignUiTimeFormatter.formatUtcHour.The add and remove replies now use that same formatter, for example "Added 21:00 CET / 15:00 EST to your availability."
Found in the wiki audit for TFMCWeb #305. Tests:
CampaignMenusCoverageTest(86) andCampaignUiTimeFormatterTestpass locally. No new branches, so coverage is unchanged.🤖 Generated with Claude Code