Repository navigation
fix: drop skins with no model and fix the cart's hull smoke bone - #79
Conversation
Eleven plane and airship skins (Prism, Norain, Zerratoris and Oseni) are listed under skins: but no ModelEngine blueprint exists for them, so every start logs "references missing ModelEngine model" and the skins can never be picked. Remove those entries; the built skins stay. The wooden cart's hull lists a vfx1 bone the model does not have (it has vfx, vfx2 and vfx3), which logged "has no bone called vfx1" on every cart load and left one smoke point unused. Use vfx3, the rear bone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
github-actions
Bot
added
the
size:M
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
Config-only cleanup of two warnings that Main logs every day.
biplane,monoplane,cloudskimmerandgyrobomberlist 11 skins (Prism, Norain, Zerratoris, Oseni) that have no ModelEngine blueprint on Main or Dev. Each start logsSkin '…' references missing ModelEngine model '…', andSkinHandlerrefuses to switch to them, so players can never use them. This removes those 11 entries. The base skin and the 8 built variants (Black, Yellow, Purple Imvata, Revenor, Domenia, Sabarissa, Brown, Pirate) stay.vfxlistsvfx1, butwooden_cart.bbmodelonly hasvfx(front, harness),vfx2(middle) andvfx3(rear). Every cart load loggedwooden_cart has no bone called vfx1(22 times on Main today), and that hull smoke point was never shown. It now usesvfx3.No code changes. Saved vehicles are unaffected: none of Main's 116 stored vehicles uses a removed skin.
Testing
Bot test on TFMCDev01 (
~/vf-skins-test/test.js). Dev's configs matched Main's before the test./vf spawn wooden_cartloggedhas no bone called vfx1.vf reload: noreferences missing ModelEngine modellines and no VehicleFramework errors./vf spawn wooden_cartlogged no bone warnings. A biplane also spawned cleanly.Companion changes: the same config edits in ServerAssets, and the wiki skin list in TFMCWeb.
🤖 Generated with Claude Code