Adopt the §15 XSS fixture under node:test, and run it - #4
Merged
Merged
Conversation
The rule was wired; the specimen was not. A green lint run is not evidence it fires. Vendor templates/xss-lint-fixture.js byte-identical (sha256 ff94e2e4…). The test is the node:test adapter — this repo's suite is node:test, and adding vitest for one file would be a second runner that only the kit uses. covers.json names src/exporters/html.js, src/core.js, src/common.js. The test script pinned test/pdf-vfs.test.js; widening to test/*.test.js is what makes the fixture a measurement rather than decoration. Closes #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3.
Fleet: grok
Agent: grok
Ticket: #3
Why
eslint.config.jscarries the interpolated-JSON rule.test/contained exactly one file,pdf-vfs.test.js. A green lint run here proves nothing:grep -rn JSON.stringify src/is empty, so the rule has never fired. §15 is explicit that an unproven control is not coverage.The runner decision
The vitest kit cannot be adopted byte-identical: this repo's suite is
node:test. Adding vitest for one file would be a second runner that only the kit uses.MichalAFerber/gh-officealready made this call — same kit, same runner. The specimen is byte-identical; the test is the adapter.test/fixtures/xss-lint-fixture.jsff94e2e464c960086ca47940a1300ef6171b35972c9ea190126fff59988cd4ed— matchestgwab-standardstemplates/xss-lint-fixture.jsat origin/maintest/xss-lint-fixture.test.jstest/fixtures/xss-lint-covers.jsonsrc/exporters/html.js,src/core.js,src/common.js. Notbuild/build.mjsThe test script is load-bearing
origin/mainpins"test": "node … --test test/pdf-vfs.test.js". Dropping the fixture files in without widening that glob leaves the control unexecuted — the exact failure mode this ticket exists to close. Measured:the rule resolves for 9 of 9 linted files; 3 named as product sourceDraft. DevOps marks ready; Michal merges.