feat: add German language support (de-DE)#215
feat: add German language support (de-DE)#215harshanaDisa wants to merge 3 commits intoTHU-MAIC:mainfrom
Conversation
|
Hey, thanks for putting this together! Since this PR was opened, we've refactored the i18n system. Adding a new locale now only needs two changes:
See the Translation Guide and #365 (Japanese) for reference. Could you rebase onto current |
1 similar comment
|
Hey, thanks for putting this together! Since this PR was opened, we've refactored the i18n system. Adding a new locale now only needs two changes:
See the Translation Guide and #365 (Japanese) for reference. Could you rebase onto current |
Refactored the initial German language support to align with the newly introduced i18n system. Changes: - Added de-DE.json with all translation keys. - Registered de-DE in supportedLocales. - Localized fallback strings in the generation pipeline. - Updated UI components to dynamically use supportedLocales. - Added Azure TTS German voices. - Made prompts generic for multiple languages. Closes THU-MAIC#215
5c7bc47 to
b194fc3
Compare
|
Hey @wyuc! Thanks for the review and the pointers. I've rebased the PR onto the current Here is what's been updated:
Let me know if everything looks good or if there's anything else that needs adjusting! |
|
Quick update: I've fixed the CI failures related to the recent refactor. Changes included:
CI should pass now! |
|
Hey, thanks for the rebase and CI fixes! The Could you trim this PR down to just the two i18n files? The generation pipeline changes can go in a follow-up PR. Happy to merge the translation once it's scoped down. |
Summary
Related Issues
Changes
Type of Change
Verification
Steps to reproduce / test
What you personally verified
Evidence
pnpm check && pnpm lint && npx tsc --noEmit)Checklist