Fix workspace gaps: test deps, bunfig, TSX, Windows PATH#2
Merged
Conversation
…indows PATH - Merge test-side npm/tsDeps into devDependencies (not dependencies) in BunTypeScriptTests.npmInstall, matching upstream Mill's test dep handling - Propagate bunfig.toml and .npmrc into compile, bundle, run, and test workspaces on both TypeScript and Scala.js sides - Add .tsx fallback entrypoints (main.tsx, index.tsx) for React-style projects - Make findOnPath respect PATHEXT on Windows (bun.exe, bun.cmd) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Unit tests: PATHEXT executable candidate generation (4 cases) - Integration test: test-only deps land in devDependencies, not dependencies - Integration test: bunfig.toml propagates to compile workspace - Integration test: TSX entrypoint fallback (.tsx resolved when no .ts entry) - Fix bunfigFiles to use Task.Input for sandbox-safe workspace root access Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add removeInstallOnlyConfigs to strip .npmrc from compile/bundle/test workspaces after tscCopySources copies it from the source tree - Deduplicate test devDeps against outer package names to avoid version conflicts in the merged package.json - Use Task.Source for npmRc in BunScalaJSModule for sandbox-safe access - Add Scala.js bunfig propagation integration test covering linked, compile executable, and test workspaces - Separate typescript-bunfig moduleDir from workspace root to prove explicit propagation (not source tree walk) - Assert is-even stays out of test devDependencies Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code