Skip to content

fix(ci): remove bun install from release workflow#32

Merged
arcaputo3 merged 1 commit into
mainfrom
fix/release-ci
Apr 2, 2026
Merged

fix(ci): remove bun install from release workflow#32
arcaputo3 merged 1 commit into
mainfrom
fix/release-ci

Conversation

@arcaputo3
Copy link
Copy Markdown
Contributor

The mill-bun-plugin migration removed package.json, but the release workflow still had bun install which fails without it. This caused the v0.5.0 release to fail.

After merging, we'll need to delete and re-push the v0.5.0 tag to re-trigger the release.

🤖 Generated with Claude Code

The mill-bun-plugin handles npm dependency installation via bunInstall
task — no package.json exists at the repo root anymore.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude Bot commented Apr 2, 2026

Code Review

Summary: This is a targeted, correct fix. The removal of the bun install step is the right call — there's no package.json anymore after the mill-bun-plugin migration, so the step would always fail.

Observations

  • Change is correct and minimal. Removing a step that has no valid preconditions is the right approach; no other code needs to change.
  • "Setup Bun" step is still justified. Even without bun install, Bun itself likely still needs to be on PATH because mill-bun-plugin invokes it internally when running ./mill agent.test. Keeping the setup step is correct.
  • CI workflow (ci.yml) already doesn't have bun install, so this aligns the release workflow with CI.

Minor Note

The PR description mentions needing to delete and re-push the v0.5.0 tag after merging. Worth double-checking that the tag delete/re-push is coordinated carefully — force-pushing a tag that may already be referenced (e.g. by a partial GitHub Release draft) could leave orphaned release artifacts. If the GitHub Release was already created for v0.5.0, delete the release object before re-pushing the tag.

Verdict

Approved. The change is correct, minimal, and well-motivated. No concerns with code quality, security, or test coverage — the fix is purely CI configuration.

Generated with Claude Code

@arcaputo3 arcaputo3 merged commit 7769241 into main Apr 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant