feat(security): enforce strict markdown sanitization in song rendering#145
Draft
JaniL wants to merge 1 commit into
Draft
feat(security): enforce strict markdown sanitization in song rendering#145JaniL wants to merge 1 commit into
JaniL wants to merge 1 commit into
Conversation
Move markdown rendering into a dedicated helper and apply an explicit strict sanitize schema instead of relying on implicit plugin defaults. Only a narrow set of markdown tags is allowed and links are constrained to http/https before HTML is injected into the page.
ConcernedHobbit
approved these changes
Apr 18, 2026
ConcernedHobbit
left a comment
ConcernedHobbit
left a comment
Collaborator
There was a problem hiding this comment.
Approved with a suggestion to drop http link support
| a: ["href", "title"], | ||
| }, | ||
| protocols: { | ||
| href: ["http", "https"], |
Collaborator
There was a problem hiding this comment.
Screw it, let's lock it down to https here. I don't see a reason to support outgoing http links.
Collaborator
There was a problem hiding this comment.
Suggested change
| href: ["http", "https"], | |
| href: ["https"], |
Collaborator
|
Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpandhttpsto prevent unsafe URL schemes before HTML is injectedValidation
npm run lint(passes; existing Next.js config warning remains unrelated to this change)