Repository navigation
fix(upstream): ship the agents and references imported files use - #24
Merged
Merged
Conversation
/ship and /webperf spawn personas from agent-skills' agents/, and eleven imported skills link to ../../references/. Neither directory was copied, so in a generated project the subagents did not exist and every link was dead. The personas also link to ../docs/agents.md. upstream.yaml now declares them under `support`: upstream path -> where it lands under .claude/, chosen so every relative link resolves with no imported byte edited. Sync keeps them in knowledge/support/<source>/. A support file is an artifact like the others, so the checklist, checksums, the exists/modified protection and stale removal all apply unchanged. It is written only while something from its source is, and a project's own .claude/agents/<name>.md is left alone, which is what /ship expects. Lint rejects a support file no declaration covers and a declaration with nothing synced under it. Closes #22
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22.
Problem
/shipand/webperfspawn personas from agent-skills'agents/, and eleven imported skills link to../../references/. Neither directory was copied, so in a generated project the subagents did not exist and every link was dead. The personas themselves link to../docs/agents.md.Change
knowledge/upstream.yamldeclares these files undersupport: upstream path -> where it lands under.claude/.The targets keep the upstream relative layout, so every link resolves with no imported byte edited.
npm run synckeeps the files inknowledge/support/agent-skills/and records them inupstream.lock.json.A support file is an artifact like the others (
type: support), so the checklist, checksums, theexists/modifiedprotection and stale removal all apply unchanged:.claude/agents/code-reviewer.mdis left alone, which is what/shipexpects: it prefers project-defined personas..claude/and cannot land on rules, skills, commands or the manifest.support/that no declaration covers, and a declaration with nothing synced under it.--jsongainsselection.supportandreport.counts.support; no existing field changes.Not fixed here
ship.md:24mentionsreferences/orchestration-patterns.mdas plain text, not a link. It does not resolve upstream either (plugin files live outside the project), and it is on the Agent Teams side path only. Changing it means editing an imported file, so it belongs upstream.Verification
npm run checkpasses.supportmanifest, the bundled CLI's counts and--json, and a test that every relative.mdlink in a generated Rails project resolves. That last test failed on 11 skills and 4 personas before this change.generate --framework rails --write --yeswrites the 12 files, andcheckright after reports up to date.