Repository navigation
mobile: hall menu v2 — plate selection, bottom summary bar, expanded sheet, nutrition label #91
Description
Part of #87 (wave 3). Blocked by: #90.
Rebuild halls/[slug] per the canvas:
- Dish rows gain a + button → stepper when in the plate; info affordance → nutrition label screen (full FDA-style label per the canvas — requires extending shared's parseCategoryItems to also capture the data-*-dv attributes, which it currently drops; shared change with red-first tests, additive so web is unaffected).
- Plate: in-memory selection state; bottom bar (items · cal + macro line + LOG button, canvas styling) appears when non-empty; tap bar → expanded sheet (steppers, per-item cal, totals grid, LOG N ITEMS); one tap writes one LogEntry per item at loggedAt=now via existing SqliteLogStorage.
- OpenFoodFacts entry point: the sheet's "Add something else" row → search UI using shared's existing openFoodFacts client (SEARCH only; barcode scanning needs a native dep — explicitly out of scope, note it).
- Post-log comparison prompt parity is NOT in scope (web-only today; keep mobile's flow unchanged apart from the plate).
TDD: plate math (totals, add/remove/step) red-first in jest as pure functions; emulator verification with screenshots (bar collapsed/expanded, label screen, OFF search) — the plate-vs-content occlusion class of bug (see PR #78/#84 history) must be checked: last dish row reachable with the bar up. Tokens/components only; jest + tsc + shared tests. Standing policy per #87; coordinate emulator use.
Activity
TSVRN9 commentedon Aug 19, 2026
Implemented in PR #106 (branch
mobile/plate-logging, stacked onmobile/swipe-shell/ PR #104 per standing policy). Not merged — left for review.What changed
umassDining.ts,types.ts):parseCategoryItemsnow also captures thedata-*-dvattributes it was dropping — 8 new optionalNutritionFactsfields (totalFatDv,satFatDv,cholesterolDv,sodiumDv,totalCarbDv,dietaryFiberDv,sugarsDv,proteinDv, allnumber | null). Additive/optional, so web is unaffected (verified: no existing constructor sets them, no web spec asserts exact nutrition-object shape). Includes the real feed'sdata-cholesterol_dvunderscore quirk (every other-dvattribute is hyphenated).openFoodFacts.ts): the issue named "shared's existing openFoodFacts client" as SEARCH-capable, but onlylookupBarcode(barcode-only) existed. AddedsearchProducts(OFF'scgi/search.pl, field-slimmed) and extracted the nutriments→NutritionFactsmapper so both functions share the same per-serving/100g-fallback logic. This file is outside the issue's enumerated file ownership — touched because the premise required it; called out for review.totalItemCount,toLogEntries, andlistBottomPadding(the occlusion-fix helper, see below).buildLabelRows, DV% formatting, blank-DV vs. no-DV-column distinction).<Modal>-based components (not routed screens — see structural note below), each with a render smoke test.+/stepper and an info affordance; bottom bar shown once the plate is non-empty, opens the expanded sheet; LOG writes oneLogEntryper plate row (servings= that row's count, not one row per unit — matchestoday.tsx's existing"Dish × N"display andrank.tsx's dedupe-by-dish-key comparison pool). Favorite-star and filter/section logic left untouched. Post-log comparison-prompt parity intentionally not added (out of scope per issue)._layout.tsxuntouched —NutritionLabel/PlateSheetare RN Modals, not routedStack.Screens, sinceMenuItemdoesn't need to survive Expo Router's string-only search-param serialization and neither needs its own back-stack entry.contentContainerStyle.paddingBottomtracks the plate bar'sonLayout-measured height, andlistBottomPaddingcollapses it to0once the plate empties — even though the bar's last-measured height is still sitting in state.PlateBaralso pads for the bottom safe-area inset itself (useSafeAreaInsets, already provided by expo-router's root — no_layout.tsxchange).Red/green (TDD)
All red evidence captured by writing the test first, running it against pre-implementation code, confirming failure, then implementing:
shared/src/umassDining.test.ts(%DV parsing): red —AssertionError: undefined !== 4(captured viagit stashof the implementation, re-run,git stash pop) → green after implementing.shared/src/openFoodFacts.test.ts(searchProducts): red —SyntaxError: ... does not provide an export named 'searchProducts'→ green after implementing (existinglookupBarcodetests unaffected, confirmed unchanged output shape).mobile/src/lib/plate.test.ts: red —Cannot find module './plate'→ green (18 tests, includinglistBottomPadding's stale-height case).mobile/src/lib/nutritionLabel.test.ts: red —Cannot find module './nutritionLabel'→ green (8 tests).PlateBar,NutritionLabel,PlateSheet) written against the finished components (render + interaction wiring, not red-first, since they're integration-style checks of already-implemented UI).Verification
pnpm --filter @udine/shared test— 116/116 pass.cd mobile && npx tsc --noEmit— clean.pnpm --filter mobile test— 19 suites / 101 tests pass.pnpm --filter web check— pre-existing failures only (missingweb/.envin this worktree; confirmed unrelated by stashing the diff and re-running against identical worktree state).fix/oauth-cold-startfor most of this session and only moved tomainnear the end; couldn't independently confirm it was clean/free (worktree isolation blocksgitcalls against the shared checkout), and reviewers were noted as occupying the emulator. Flagging for the orchestrator rather than risking a conflict — screenshots (bar collapsed/expanded, label screen, OFF search, last-row reachability) are still outstanding.mobile: don't clear the plate or lose data on a partial logPlate fail…
mobile: You pane v2 -- macros, log, hall completion, top foods, favor…
mobile: hall menu v2 — plate selection, bottom summary bar, expanded …
mobile: don't clear the plate or lose data on a partial logPlate fail…
mobile: hall menu v2 — plate selection, bottom summary bar, expanded …
mobile: don't clear the plate or lose data on a partial logPlate fail…
mobile: You pane v2 -- macros, log, hall completion, top foods, favor…
mobile: 3-pane swipe shell + Home pane v2 (#104)
mobile: You pane v2 -- macros, log, hall completion, top foods, favor…
mobile: You pane v2 -- macros, log, hall completion, top foods, favor…
mobile: hall menu v2 — plate selection, bottom summary bar, expanded …
mobile: don't clear the plate or lose data on a partial logPlate fail…
mobile: hall menu v2 — plate selection, summary bar, nutrition label,…