Skip to content

Add DiceLib as a dependency#113

Merged
QMalcolm merged 3 commits into
mainfrom
qmalcolm--add-dice-lib-dependency
Mar 31, 2026
Merged

Add DiceLib as a dependency#113
QMalcolm merged 3 commits into
mainfrom
qmalcolm--add-dice-lib-dependency

Conversation

@QMalcolm

@QMalcolm QMalcolm commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

Summary by Bito

This PR adds DiceLib as an external dependency to handle dice rolling operations, replacing the internal Dice module with the library's Basic module for consistency across the application.

Detailed Changes
  • Adds DiceLib dependency to mix.exs and updates mix.lock in mix.exs
  • Removes the internal ExTTRPGDev.Dice module from dice.ex and its test file from dice_test.exs
  • Updates aliases to use DiceLib.Basic in characters.ex, character.ex, and server.ex

@bito-code-review

bito-code-review Bot commented Mar 31, 2026

Copy link
Copy Markdown

Code Review Agent Run #50fa92

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: b44eef5..020769c
    • apps/ex_ttrpg_dev/lib/characters.ex
    • apps/ex_ttrpg_dev/lib/characters/character.ex
    • apps/ex_ttrpg_dev/lib/dice.ex
    • apps/ex_ttrpg_dev/mix.exs
    • apps/ex_ttrpg_dev/test/dice_test.exs
    • apps/ttrpg_dev_cli/lib/cli/server.ex
    • mix.lock
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at dev.6y28p@passmail.net.

Documentation & Help

AI Code Review powered by Bito Logo

@QMalcolm QMalcolm left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
4 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@bito-code-review

Copy link
Copy Markdown

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted Summary
New Feature - Add DiceLib Dependency
Adds DiceLib as a dependency in mix.exs and updates mix.lock to include the new package for external dice rolling functionality.
Feature Improvement - Refactor Dice Usage in Core Modules
Updates aliases from internal ExTTRPGDev.Dice to DiceLib.Basic across Characters, Character, and Server modules.
Other Improvements - Remove Internal Dice Module
Removes the internal Dice module implementation and its associated test file as functionality is now handled by DiceLib.

@QMalcolm QMalcolm merged commit 55fa671 into main Mar 31, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant