Repository navigation
197: Limit OAuth team management to OAuth-managed teams - #200
Draft
JaeYeonLee0621 wants to merge 3 commits into
Draft
JaeYeonLee0621 wants to merge 3 commits into
JaeYeonLee0621 wants to merge 3 commits into
Conversation
JaeYeonLee0621
changed the title
JaeYeonLee0621
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Teams that an admin assigned manually are removed automatically when the user logs in again.Assumption: The OAuth login flow calls a team sync function. It syncs the user's teams against the team names from the OAuth provider only, so any team not in that list, including admin-assigned ones, gets removed.Solution: Limit the sync to OAuth-managed teams. During sync, add or remove only teams that come from OAuth, and leave manually assigned teams untouched.