Pin SwiftMail to upstream 124e3cc now that the RFC 2231 fix is merged - #159
Merged
Merged
Conversation
Cocoanetics/SwiftMail#233 merged upstream as 124e3cc, so the fork main was reset to it and is a pure mirror again with no deviation. App and NSE now pin packages.SwiftMail.revision to that commit instead of the fork-only d87295e3, which carried the first draft of the same fix. Behavioural difference from the previous pin on Apple platforms: an RFC 2231 extended filename with a blank charset and non-ASCII bytes now falls back to the literal filename parameter instead of being read as UTF-8. Nothing else in the receive path changed; the other review fixes affect non-Apple platforms only. Verification: resolved SwiftMail checkout proven at 124e3cc by rev-parse before and after the build; TabMail and TabMailNotificationService build with only the documented benign App Intents diagnostic; EML consumer suites (175 tests in 7 suites) pass against the new pin. The IOS-IMAP-016 record and companion memory 126 are updated with the merge and sync state. Signed-off-by: Kwang Moo Yi <kmyi@tabmail.ai> (cherry picked from commit cc6b90d) Signed-off-by: Kwang Moo Yi <kmyi@tabmail.ai>
tabmail-kmyi
force-pushed
the
agent/ios-swiftmail-repin-124e3cc
branch
from
September 11, 2026 16:59
6e464d4 to
1745cc2
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cocoanetics/SwiftMail#233 merged upstream as 124e3cc. Fork
mainis reset to it (pure mirror, zero deviations) and app + NSE are re-pinned from the fork-only d87295e3 to 124e3cc.Behavioural difference on Apple platforms versus the previous pin: an RFC 2231 extended filename with a blank charset and non-ASCII bytes now falls back to the literal filename instead of being read as UTF-8. Nothing else in the receive path changed. A fresh-context review confirmed the pin, the single shared revision, the Darwin-only delta, and that every app consumer of a nil parsed filename has a generated-name fallback.
Verification: resolved checkout proven at 124e3cc by rev-parse before and after the build; TabMail and TabMailNotificationService build with only the documented benign App Intents diagnostic; EML consumer suites (EmlParsing, EmlMarker ×2, AttachmentFilenameContainment, EmlRender, GmailProviderEnvelope, EmailRenderPipeline: 175 tests in 7 suites) pass. Send/draft suites were not re-run: #233 touches only the receive-side decoder.
Also updates the IOS-IMAP-016 record and companion memory 126 with the sync state.
Refs #10.
🤖 Generated with Claude Code