Skip to content

chore: ignore artifacts directory - #54

Merged
zwpaper merged 2 commits into
mainfrom
chore/ignore-artifacts
May 8, 2026
Merged

chore: ignore artifacts directory#54
zwpaper merged 2 commits into
mainfrom
chore/ignore-artifacts

Conversation

@icycodes

@icycodes icycodes commented May 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Added artifacts directory to .gitignore to prevent local Harbor job artifacts from being tracked.
  • Added a comment explaining the purpose of the ignore rule.

Test plan

  • Verified that the artifacts directory is now ignored by git.

🤖 Generated with Pochi | Task

Keep the artifacts of Harbor jobs locally for debugging purposes; do not push to remote.

🤖 Generated with [Pochi](https://getpochi.com) | [Task](https://app.getpochi.com/share/p-9e2e56fdc5d14b3eb671eb9958802a98)

Co-Authored-By: Pochi <noreply@getpochi.com>
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-05-08 07:33 UTC

@icycodes
icycodes requested review from DESU-CLUB and zwpaper May 8, 2026 07:18

@DESU-CLUB DESU-CLUB left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To clarify the scope of the fix: This PR does not remove the artifact feature, it will just prevent future runs from sending the artifact to Github

Artifacts can still be viewed locally to debug tasks and to add more visibility when doing analysis of benchmarks

Comment thread .gitignore Outdated
Co-authored-by: Wei Zhang <kweizh@tabbyml.com>
@zwpaper
zwpaper merged commit 27f0abc into main May 8, 2026
1 check passed
@zwpaper
zwpaper deleted the chore/ignore-artifacts branch May 8, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants