chore: ignore artifacts directory - #54
Merged
Merged
Conversation
Keep the artifacts of Harbor jobs locally for debugging purposes; do not push to remote. 🤖 Generated with [Pochi](https://getpochi.com) | [Task](https://app.getpochi.com/share/p-9e2e56fdc5d14b3eb671eb9958802a98) Co-Authored-By: Pochi <noreply@getpochi.com>
|
DESU-CLUB
approved these changes
May 8, 2026
Collaborator
There was a problem hiding this comment.
LGTM
To clarify the scope of the fix: This PR does not remove the artifact feature, it will just prevent future runs from sending the artifact to Github
Artifacts can still be viewed locally to debug tasks and to add more visibility when doing analysis of benchmarks
zwpaper
reviewed
May 8, 2026
Co-authored-by: Wei Zhang <kweizh@tabbyml.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
artifactsdirectory to.gitignoreto prevent local Harbor job artifacts from being tracked.Test plan
artifactsdirectory is now ignored by git.🤖 Generated with Pochi | Task