fix(site): make pending_models optional and update devMode check - #55
Merged
Conversation
- Cast zealtConfig to explicitly make pending_models optional, preventing TS errors when the field is omitted from config.json. - Update devMode logic to check process.env.NODE_ENV === "development" in addition to the URL query param. 🤖 Generated with [Pochi](https://getpochi.com) | [Task](https://app.getpochi.com/share/p-2039d4e2d1ed4e21bb3baa207943d5b6) Co-Authored-By: Pochi <noreply@getpochi.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zealtConfigto explicitly makepending_modelsoptional, preventing TypeScript compilation errors and runtime issues when the field is omitted fromconfig.json.devModelogic to checkprocess.env.NODE_ENV === "development"in addition to the URL query parameter for better developer experience.Test plan
pending_modelsfrom.zealt/config.jsondoes not break the build or cause runtime errors on the leaderboard and tasks pages.devModecorrectly defaults to true in development environments.🤖 Generated with Pochi | Task