feat: add proactive command monitors - #1894
Open
zhanba wants to merge 2 commits into
Open
Conversation
Add task-scoped monitor jobs so agents can receive command output events without polling while preserving existing background command semantics. 🤖 Generated with [Pochi](https://getpochi.com) Co-Authored-By: Pochi <noreply@getpochi.com>
Keep the environment prompt snapshot aligned with the new command and monitor job descriptions. 🤖 Generated with [Pochi](https://getpochi.com) Co-Authored-By: Pochi <noreply@getpochi.com>
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (46.59%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1894 +/- ##
==========================================
- Coverage 36.94% 31.04% -5.91%
==========================================
Files 770 779 +9
Lines 81173 82120 +947
Branches 3697 4363 +666
==========================================
- Hits 29990 25493 -4497
- Misses 51070 56508 +5438
- Partials 113 119 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startMonitortool with task-scoped monitor IDs, timeout/persistence controls, cancellation, and active-monitor environment contextexecuteCommandtranscripts and durable completion notifications while preventing duplicate completion notifications for monitor jobsTest plan
bun checkbun tsc@vscode/test-electrontimed out during startup after 15 seconds, before assertions)Notes
TerminalShellExecution.read()exposes a combined stream, so its monitor events can include stderr.🤖 Generated with Pochi