feat(vscode): promote timed out commands to background jobs - #1930
Open
zhanba wants to merge 3 commits into
Open
feat(vscode): promote timed out commands to background jobs#1930zhanba wants to merge 3 commits into
zhanba wants to merge 3 commits into
Conversation
Keep long-running commands alive and interactive after foreground timeout by adopting the original PTY into a background terminal, while preserving output and UI metadata. 🤖 Generated with [Pochi](https://getpochi.com) | [Task](https://app.getpochi.com/share/p-59931c0d563a44bcbfd37fb93d8271a4) Co-Authored-By: Pochi <noreply@getpochi.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1930 +/- ##
==========================================
+ Coverage 33.32% 33.65% +0.33%
==========================================
Files 778 780 +2
Lines 83120 83628 +508
Branches 4897 4861 -36
==========================================
+ Hits 27696 28144 +448
- Misses 55304 55364 +60
Partials 120 120 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Keep promoted commands visually distinct from commands started in the background while presenting the transition as one concise, durable status. 🤖 Generated with [Pochi](https://getpochi.com) | [Task](https://app.getpochi.com/share/p-59931c0d563a44bcbfd37fb93d8271a4) Co-Authored-By: Pochi <noreply@getpochi.com>
Keep the original non-interactive process running after the foreground wait expires and clarify timeout behavior across CLI and VS Code. 🤖 Generated with [Pochi](https://getpochi.com) | [Task](https://app.getpochi.com/share/p-59931c0d563a44bcbfd37fb93d8271a4) Co-Authored-By: Pochi <noreply@getpochi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-ptycoverageTest plan
bun checkpackages/vscode,packages/common, andpackages/vscode-webuibun turbo test:integration(three attempts failed before E2E execution while downloading VS Code 1.108.0 with TLSECONNRESET)Notes
bun.lockmodification is intentionally excluded from this PR.🤖 Generated with Pochi | Task