Skip to content

fix(vscode-webui): refine i18next ESLint rules to reduce false positives #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZHallen122 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(vscode-webui): refine i18next ESLint rules to reduce false positives #642

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e056188
fix(vscode-webui): refine i18next lint rules to reduce false positives
ZHallen122 Oct 31, 2025
c8aa3e3
Merge branch 'main' into eslint-approve
ZHallen122 Oct 31, 2025
429d753
style(eslint): format jsx-attributes array for better readability
ZHallen122 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/vscode-webui/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,16 @@ export default [
"i18next/no-literal-string": [
"error",
{
mode: "jsx-text-only", // only check jsx
mode: "jsx-only", // limit to JSX text and attributes to reduce noise
// Only check user-facing attributes; ignore design/technical attrs like className/variant/size/id
"jsx-attributes": {
include: ["^title$", "^alt$", "^placeholder$", "^label$"],
},
// Ignore developer-oriented strings passed to specific utility calls
callees: {
// Do not validate any function call arguments globally to reduce noise
exclude: [".*"],
},
words: {
exclude: [
// Numbers and common symbols
Expand All @@ -38,6 +47,10 @@ export default [
"^(px|rem|em|%|vh|vw|auto|none|inherit|KB|MB|GB|ms|s|min|h)$",
// Boolean and null values
"^(true|false|null|undefined)$",
// Single letters (initials)
"^[A-Za-z]$",
// Brand names
"^Pochi$",
],
},
},
Expand Down