Skip to content

Add Python Basic Examples#38

Open
enpuyou wants to merge 9 commits intomasterfrom
python-basic
Open

Add Python Basic Examples#38
enpuyou wants to merge 9 commits intomasterfrom
python-basic

Conversation

@enpuyou
Copy link
Copy Markdown
Collaborator

@enpuyou enpuyou commented Jun 9, 2021

This PR:

  • Add some basic Python examples determining whether a value is in a container
  • Add experiment commands and results
  • Add a custom data generation function and JSON schema for dict type

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #38 (cdeb3df) into master (865dc2d) will decrease coverage by 1.37%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   88.32%   86.95%   -1.38%     
==========================================
  Files          17       17              
  Lines         668      682      +14     
  Branches      147      150       +3     
==========================================
+ Hits          590      593       +3     
- Misses         60       71      +11     
  Partials       18       18              
Flag Coverage Δ
unittests 86.95% <21.42%> (-1.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
speedsurprises/lists/python_basic.py 65.95% <21.42%> (-18.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865dc2d...cdeb3df. Read the comment docs.

@enpuyou
Copy link
Copy Markdown
Collaborator Author

enpuyou commented Jun 9, 2021

Will add some tests for the new functions.

@gkapfham gkapfham self-requested a review June 9, 2021 18:45
@gkapfham
Copy link
Copy Markdown
Collaborator

gkapfham commented Jun 9, 2021

Hello @enpuyou! Thanks for making this PR. I am going to make a few small stylistic changes to it (e.g., do not use a parameter called dict since that is also the name of the type in Python). After I am done with those changes this afternoon, I will merge the PR as long as all of the checks are passing.

Please let me know if you have any questions or comments about this plan. Thanks again for finishing this PR! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants