-
-
Notifications
You must be signed in to change notification settings - Fork 440
feat: render .clip thumbnails.
#1150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I just tried this PR on windows 10 (x86_64) with a simple illustration i quickly drew together and an illustration that uses a newer version of CSP and it works like expected, this will be a nice addition for my artist friend. 👍 |
|
Checked and it appears to be working as expected |
CyanVoxel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on reviewing this! Everything looks great outside of the hanging sqlite connection to the .clip file. I know it's been a while since you've submitted this PR, and I'd be more than happy to implement the change on your behalf if you don't have the time to.
fa39a91 to
6af8b5c
Compare
No worries^^ I'm kinda surprised about the indent on |
CyanVoxel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this, and the quick update!
Summary
Add support for rendering
.clipthumbnails.Fixes #1146
.clipproject files embedd an SQLite database at the end of the file which contains the thumbnail in theCanvasPreviewtable.Before
After
Sources for the file format
File used for testing
Drawing by Surendra Rajawat hosted on Clip Studio Paint's website
Tasks Completed