[spike / WIP] TMMM-237: Close JPA session early#1825
Open
mprins wants to merge 1 commit into
Open
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
mprins
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This spike attempts to release JPA resources earlier in request handling so long-running external work (HTTP proxying / GeoTools feature counting & extract generation) doesn’t keep a JPA session/transaction open longer than needed.
Changes:
- Injected
EntityManagerintoLayerExtractControllerandGeoServiceProxyController. - Changed
LayerExtractController#extractto@Transactional(readOnly = true). - Added
entityManager.close()calls in both controllers after validation steps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/org/tailormap/api/controller/LayerExtractController.java | Attempts to close the JPA session mid-request during extract request processing. |
| src/main/java/org/tailormap/api/controller/GeoServiceProxyController.java | Attempts to close the JPA session before proxying outbound requests/streaming responses. |
Comment on lines
+220
to
+222
| // after all validations we can close the JPA session | ||
| this.entityManager.close(); | ||
|
|
Comment on lines
+129
to
+131
| // after all validations we can close the JPA session | ||
| this.entityManager.close(); | ||
|
|
Comment on lines
+148
to
+150
| // after all validations we can close the JPA session | ||
| this.entityManager.close(); | ||
|
|
mprins
changed the title
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Test Results639 tests ±0 637 ✅ ±0 9m 48s ⏱️ - 1m 2s For more details on these failures, see this check. Results for commit 046f570. ± Comparison against base commit ce03f21. ♻️ This comment has been updated with latest results. |
don't wait for the external resource transaction (http / jdbc) to complete before closing the JPA session/transaction
mprins
force-pushed
the
spike/experiment_with_early_session_closing
branch
from
59c4664 to
046f570
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't wait for the external "resource transaction" (HTTP [proxy] / JDBC [extract]) to complete before closing the JPA session/transaction