Renaming PublicKey and PrivateKey Classes#257
Open
kmy504 wants to merge 3 commits into
Open
Conversation
- to SwiftyRSA.PublicKey, SwiftyRSA.PrivateKey
objc[13181]: Class PublicKey is implemented in both /System/Library/PrivateFrameworks/MessageProtection.framework/MessageProtection (0x24e9dbcc0) and /private/var/containers/Bundle/Application/AA0EFB35-6414-4395-98E5-1F3AFD934168/Band.app/Frameworks/SwiftyRSA.framework/SwiftyRSA (0x10f18a1e0). One of the two will be used. Which one is undefined.
Fixed 'Class PublicKey is implemented both'
Contributor
|
@kmy504 This is good update and thanks for the contribution. I'll look into how this might affect our internal usage of the framework and get back on this. |
|
Hello, When is this going to be merged? I have the same collision on my project. |
Author
|
@pc-scoop Apple has been implement same name with PublicKey. So if some project use Apple's framework like MessageProtection framework, It would be cause name collision. So I wrapped SwiftyRSA's struct that cause name collision with SwiftyRsa enum extension to look like a namespace. @Misantrofia Use my forked repository before merge. :) |
|
Any updates on when this will be merged ? |
|
@pc-scoop Any updates? |
|
we still have this warning would love it to be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Our project currently faces a significant name collision issue. Specifically, the PublicKey class is implemented in both the MessageProtection framework and the SwiftyRSA framework. This is causing the following warning message to appear:
To resolve this issue, I propose renaming the PublicKey and PrivateKey classes within the SwiftyRSA framework to SwiftyRSAPublicKey and SwiftyRSAPrivateKey, respectively. This change will address the name collision and improve code readability and maintainability.
The changes are as follows:
PublicKey -> SwiftyRSA.PublicKey
PrivateKey -> SwiftyRSA.PrivateKey
I believe these changes will positively impact the project. I appreciate your review and feedback on this matter.
Thank you.