feat: implement client migration functionality with proposal and acce…#350
Merged
mikewheeleer merged 2 commits intoMay 27, 2026
Conversation
|
@Oluwasuyi-Timilehin Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes #319
Summary
This PR adds secure client migration support to the
contracts/escrowpackage.The feature enables the current escrow client to propose a new client address and allows the proposed client to accept the migration later.
The pending migration proposal is stored in Soroban temporary storage with a TTL, so stale proposals automatically expire.
What changed
PendingClientMigrationand migration flow incontracts/escrow/src/migration.rspropose_client_migrationaccept_client_migrationhas_pending_client_migrationget_pending_client_migrationcontracts/escrow/src/lib.rscontracts/escrow/src/test/client_migration.rsdocs/escrow/migration.mdBehavior details
propose_client_migration:client_migration_proposedaccept_client_migration:EscrowContractData.clientclient_migration_acceptedTTL behavior ensures proposals cannot be accepted after expiry.
Tests
The following cases were added and validated:
Validation
cargo testincontracts/escrowpasses with36 passed; 0 failedFiles changed
contracts/escrow/src/migration.rscontracts/escrow/src/lib.rscontracts/escrow/src/test/client_migration.rsdocs/escrow/migration.mdNotes for reviewers
#closes