test(escrow): add transient TTL expiry tests#363
Merged
Conversation
- Add 15 deterministic tests in contracts/escrow/src/test/ttl_tests.rs covering all six TTL helpers (compute_expiry, store_with_ttl, read_if_live, extend_if_below_threshold, remove_transient, has_transient) for both PENDING_APPROVAL_TTL_LEDGERS (7 days) and PENDING_MIGRATION_TTL_LEDGERS (21 days) - Tests advance env.ledger().sequence_number to prove Soroban auto-eviction: read_if_live returns Some before TTL elapses and None after - extend_if_below_threshold: returns false for absent key, returns true and keeps entry live past original expiry after bump - Wire ttl_tests module into contracts/escrow/src/test/mod.rs - Add rustdoc comments to all public TTL functions and constants in ttl.rs; remove per-function #[allow(dead_code)] (crate-level allow covers it) - Update docs/escrow/storage-ttl.md with accurate test names, helper API table, security notes, and reviewer checklist Closes Talenttrust#328
|
@paulinaapeh8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #328