Conversation
add api to query device's sdk states
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # tapsdk/__init__.py # tapsdk/parsers.py
Detect protocol from GATT and return TapSDK or TapSDK2 from one entry point, with shared transport and DeviceInfo. Refs #36 Co-authored-by: Cursor <cursoragent@cursor.com>
Docs check
|
Address docs-verify gaps for PR #50: tutorial/readme happy path, TapSDK2 reference, enums/events, v1 how-to labels, and connection model. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Workflow run: https://github.com/TapWithUs/tap-python-sdk/actions/runs/30809935445 Docs check
|
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Workflow run: https://github.com/TapWithUs/tap-python-sdk/actions/runs/30822789192 Docs check
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
This also closes #49 on the sdk side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TapSDK2(framed v2 protocol) alongside existingTapSDK, plus encoder/parsers/features needed for v2 devices.tapsdk._transport), protocol detect (c3ff000e→ v2), andDeviceInfoacross both SDKs.await connect()factory returnsTapSDKorTapSDK2; register callbacks thenawait start(). Docs +examples/connect.pyupdated.Closes #36
Test plan
pytest+flake8green on CIexamples/connect.pyon a v1 TapXR — expectProtocol: v1, device info, taps in controller modeexamples/v2.py/connect()on a v2 device — expectProtocol: v2set_input_mode/set_input_typeHID semantics still match docs (Text/ControllerText = HID; Controller + KEYBOARD = SDK taps, no HID)Made with Cursor