Improve archery no-layout guidance and actionable suggestions - #3
Merged
TaylorHere merged 5 commits intoMar 17, 2026
Merged
Conversation
Co-authored-by: TaylorHere <TaylorHere@users.noreply.github.com>
Co-authored-by: TaylorHere <TaylorHere@users.noreply.github.com>
Co-authored-by: TaylorHere <TaylorHere@users.noreply.github.com>
Co-authored-by: TaylorHere <TaylorHere@users.noreply.github.com>
Co-authored-by: TaylorHere <TaylorHere@users.noreply.github.com>
TaylorHere
marked this pull request as ready for review
March 17, 2026 21:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
28mmto22mmso the initial A4 preset has a feasible strict-symmetry layoutdiagnoseNoLayoutReason()in shared layout logic to explain why no solution exists/api/layoutfailure responsesuggestNearbyFeasibleLayouts()to search nearby diameters and provide actionable feasible suggestionsD / n / m / s)s_minto feasible upper bound (when applicable)DD + s_min黑白靶and彩色靶显示环分数自动填满(最大数量)mode (current maximize behavior)指定数量(尽量接近)mode with user-entered target countlayoutMode+desiredTargetsWhy
Users were frequently seeing
无可行排布without clear guidance. In strict equal-spacing mode, many(page, D)pairs are mathematically unsatisfiable regardless ofs_min, so generic advice was misleading.The new behavior removes trial-and-error: after changing one parameter, users are automatically brought back to a feasible layout by adjusting other parameters.
Also, users requested richer target styles and optional score labels directly on rings.
And users wanted a direct quantity control flow: either fill the page automatically, or set a target count and get the closest feasible strict-symmetry layout.
Validation
npm run build(TypeScript + Vite build) passed inarchery/.