Skip to content

feat: getBook 요청 실패 시 에러 반환이 아닌 DB 데이터 삽입 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wooodypark merged 2 commits into from
Jul 18, 2025
Merged

feat: getBook 요청 실패 시 에러 반환이 아닌 DB 데이터 삽입 #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45b7cb4
feat: getBook 요청 실패 시 에러 반환이 아닌 DB 데이터 삽입
wooodypark Jul 16, 2025
58397a5
fix: lint 오류 수정
wooodypark Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/services/searchWellItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
SearchMemo,
SearchReview,
} from '@frolog/frolog-api';
import { Well, WellItem } from '@frolog/models';
import { Well, WellItem, Book, Category } from '@frolog/models';
const getBook = new GetBook({ accessToken: SSC_TOKEN });
const searchMemo = new SearchMemo({ accessToken: SSC_TOKEN });
const searchReview = new SearchReview({ accessToken: SSC_TOKEN });
Expand Down Expand Up @@ -75,9 +75,23 @@ export default async function searchWellItem(reqDto, user) {
const itemHashId = encodeHashId(itemId);

const isbn = wellItem.book_isbn;
let title = '';
let page = 0;
let category = 'unknown';
const book = await getBook.fetch({ isbn }).catch(handleError);
if (!book) throw new FetchError();
const { title, page, category } = book;
if (book) {
title = book.title ?? '';
page = book.page ?? 0;
category = book.category ?? 'unknown';
} else {
const bookData = await Book.findOne({
where: { isbn },
include: [{ model: Category }],
});
title = bookData?.title ?? '';
page = bookData?.page ?? 0;
category = bookData?.Category?.category_key ?? 'unknown';
}

const reviews = await searchReview
.fetch({
Expand Down