[auth] 스팀 인증 회로 차단기 추가#40
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements a resilience strategy for the Steam authentication service using Polly v8, incorporating a circuit breaker and request timeouts. It adds configuration settings, a custom exception filter to return a 503 status when the circuit is open, and unit tests to verify the behavior. The reviewer recommends using TimeProvider and FakeTimeProvider in both the resilience configuration and tests to eliminate flakiness caused by Task.Delay.
…c circuit-breaker timing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
SteamCircuitOpenException으로 변환하고, 전역 예외 필터에서 503 응답으로 처리하도록 추가하였습니다.Steam:CircuitBreaker설정과 옵션 검증 로직을 추가하였습니다.테스트
dotnet test PushAndPull.sln --no-restore를 시도하였으나 현재 환경에dotnetCLI가 없어 실행하지 못하였습니다.참고 사항
.github/PULL_REQUEST_TEMPLATE.md파일이 저장소에서 확인되지 않아 위 구조로 본문을 작성하였습니다.