Skip to content

[auth] 스팀 인증 회로 차단기 추가#40

Merged
Sean-mn merged 3 commits into
developfrom
update/steam-auth-resilience
May 10, 2026
Merged

[auth] 스팀 인증 회로 차단기 추가#40
Sean-mn merged 3 commits into
developfrom
update/steam-auth-resilience

Conversation

@Sean-mn

@Sean-mn Sean-mn commented May 8, 2026

Copy link
Copy Markdown
Member

변경 사항

  • 스팀 인증 HTTP 클라이언트에 Polly 기반 회로 차단기와 요청 타임아웃을 추가하였습니다.
  • 회로 차단 상태를 SteamCircuitOpenException으로 변환하고, 전역 예외 필터에서 503 응답으로 처리하도록 추가하였습니다.
  • 환경별 Steam:CircuitBreaker 설정과 옵션 검증 로직을 추가하였습니다.
  • 회로 차단기 동작, 타임아웃, 503 응답 변환을 검증하는 인증 테스트를 추가하였습니다.

테스트

  • dotnet test PushAndPull.sln --no-restore를 시도하였으나 현재 환경에 dotnet CLI가 없어 실행하지 못하였습니다.

참고 사항

  • .github/PULL_REQUEST_TEMPLATE.md 파일이 저장소에서 확인되지 않아 위 구조로 본문을 작성하였습니다.

@Sean-mn Sean-mn added the enhancement:개선사항 New feature or request label May 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a resilience strategy for the Steam authentication service using Polly v8, incorporating a circuit breaker and request timeouts. It adds configuration settings, a custom exception filter to return a 503 status when the circuit is open, and unit tests to verify the behavior. The reviewer recommends using TimeProvider and FakeTimeProvider in both the resilience configuration and tests to eliminate flakiness caused by Task.Delay.

Comment thread PushAndPull/PushAndPull/Domain/Auth/Config/AuthServiceConfig.cs
Comment thread PushAndPull/PushAndPull.Test/Service/Auth/SteamCircuitBreakerTests.cs Outdated
@Sean-mn
Sean-mn merged commit b242057 into develop May 10, 2026
3 checks passed
@Sean-mn
Sean-mn deleted the update/steam-auth-resilience branch May 10, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement:개선사항 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant