fix: preserve boolean private fields - #50
Merged
Merged
Conversation
davidrobertson
marked this pull request as ready for review
July 25, 2026 19:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve boolean
privatepackage metadata when sanitizing stored payloads. String values and compound keys such asprivate_keystill follow the existing secret-redaction path.Root cause
shouldRedactSecretKeytreated the standalone keyprivateas secret regardless of its value, so package metadata such as"private": truebecame"[REDACTED:secret]".Validation
node --no-warnings --test --test-name-pattern='preserves a benign private package flag' tests/redact.test.tsnode --no-warnings --test tests/redact.test.ts tests/redact-assignments.test.ts(21 tests passed)npm run typecheck