fix: harden recovery and storage behavior - #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lcm_pack_contextcompletes.0700directories and0600files.Root causes
The recovery marker was consumed when the reminder was shown, so a task could stop before retrieval completed. URI redaction assumed a nonempty username, storage permissions depended on the caller's umask, cleanup expected an existing index, and overflow search reused the 512 KiB paging limit intended for display.
Validation
npm test: 188 passednpm run typecheck: passednpm run smoke: passedumask 0003559b2e897f64e4e41141c93c4e4f124cd88ca82Risk
Overflow search now reads and lowercases each managed payload through the existing 8 MiB input bound, so broad searches across many large payloads can use more CPU. Recovery marker writes still trust the private LCM home; a hostile preexisting symlink requires prior control of that directory.