SMB device discovery strategy using mDNS/NsdManager #4536
+1,259
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NsdManagerimplementation ofSmbDeviceScannerObservable.DiscoverDeviceStrategy, to enable discover Samba servers advertised on the network using mDNS.Issue tracker
Fixes #4488
Automatic tests
Manual tests
Done
Device: Fairphone 5
OS: LineageOS 23.0 (Android 16)
With proper configuration of
avahi-daemonandsamba, Amaze is able to discover Samba servers on the same network.Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck