Skip to content

Updated default mandelmuller kickparams #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilyamandel merged 7 commits into from
Jan 28, 2026
+18 −12
Merged

Updated default mandelmuller kickparams #1450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8c5d4cd
Update constants.h
pauldisberg Jan 28, 2026
10e0344
Update changelog.h
pauldisberg Jan 28, 2026
4b1a5ac
Update whats-new.rst
pauldisberg Jan 28, 2026
32a56f4
Updated default kick parameters in program-options-list-defaults.rst
pauldisberg Jan 28, 2026
c8aeff1
Update changelog.h
pauldisberg Jan 28, 2026
953ef38
Update default kick params in compasConfigDefault.yaml
pauldisberg Jan 28, 2026
154d340
Update whats-new.rst
ilyamandel Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compas_python_utils/preprocessing/compasConfigDefault.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,9 @@ numericalChoices:
# --maximum-neutron-star-mass: 2.500000 # Default: 2.500000
# --mcbur1: 1.600000 # Default: 1.600000
# --muller-mandel-kick-multiplier-BH: 200.00 # Default: 200.00 # scaling prefactor for BH kicks when using the 'MULLERMANDEL' kick magnitude distribution
# --muller-mandel-kick-multiplier-NS: 520.00 # Default: 520.00 # scaling prefactor for NS kicks when using the 'MULLERMANDEL' kick magnitude distribution
# --muller-mandel-sigma-kick-BH: 0.300000 # Default: 0.300000 # BH kick scatter when using the 'MULLERMANDEL' kick magnitude distribution
# --muller-mandel-sigma-kick-NS: 0.300000 # Default: 0.300000 # NS kick scatter when using the 'MULLERMANDEL' kick magnitude distribution
# --muller-mandel-kick-multiplier-NS: 630.00 # Default: 630.00 # scaling prefactor for NS kicks when using the 'MULLERMANDEL' kick magnitude distribution
# --muller-mandel-sigma-kick-BH: 0.450000 # Default: 0.450000 # BH kick scatter when using the 'MULLERMANDEL' kick magnitude distribution
# --muller-mandel-sigma-kick-NS: 0.450000 # Default: 0.450000 # NS kick scatter when using the 'MULLERMANDEL' kick magnitude distribution
# --neutrino-mass-loss-BH-formation-value: 0.100000 # Default: 0.100000
# --pisn-lower-limit: 60.000000 # Default: 60.000000 # Minimum core mass for PISN [Msol]
# --pisn-upper-limit: 135.00 # Default: 135.00 # Maximum core mass for PISN [Msol]
Expand Down
10 changes: 5 additions & 5 deletions online-docs/pages/User guide/Program options/program-options-list-defaults.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,12 +629,12 @@ Default = Random number drawn uniformly from :math:`[0.0, 1.0)`
**--kick-magnitude-sigma-CCSN-BH** |br|
Sigma for chosen kick magnitude distribution for black holes (:math:`km s^{−1}`). |br|
Ignored if not needed for the chosen kick magnitude distribution. |br|
Default = 265.0
Default = 217.0

**--kick-magnitude-sigma-CCSN-NS** |br|
Sigma for chosen kick magnitude distribution for neutron stars (:math:`km s^{−1}`). |br|
Ignored if not needed for the chosen kick magnitude distribution. |br|
Default = 265.0
Default = 217.0

**--kick-magnitude-sigma-ECSN** |br|
Sigma for chosen kick magnitude distribution for ECSN (:math:`km s^{−1}`). |br|
Expand Down Expand Up @@ -993,15 +993,15 @@ Default = 200.0

**--muller-mandel-kick-multiplier-NS** |br|
Scaling prefactor for NS kicks when using the `MULLERMANDEL` kick magnitude distribution |br|
Default = 520.0
Default = 630.0

**--muller-mandel-sigma-kick-BH** |br|
Scatter width for BH kicks when using the `MULLERMANDEL` kick magnitude distribution |br|
Default = 0.3
Default = 0.45

**--muller-mandel-sigma-kick-NS** |br|
Scatter width for NS kicks when using the `MULLERMANDEL` kick magnitude distribution |br|
Default = 0.3
Default = 0.45

.. _options-props-N:

Expand Down
4 changes: 4 additions & 0 deletions online-docs/pages/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ What's new

Following is a brief list of important updates to the COMPAS code. A complete record of changes can be found in the file ``changelog.h``.

**03.28.00 January 28, 2026**

* Updated the default values for the Mandel-Müller kick prescription to a magnitude of 630 km/s and a sigma of 0.45, as calibrated by Disberg et al. (2026) to the results of Disberg & Mandel (2025).

**03.27.02 December 16, 2025**

* Fixed a bug in the assignment of kick direction angles
Expand Down
4 changes: 3 additions & 1 deletion src/changelog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1686,6 +1686,8 @@
// - Corrected luminosity evolution for CH stars (issue #1443)
// 03.27.03 IM - December 16, 2025 - Defect repair:
// - Fix issue #1446: Theta and phi variables are flipped when assigning kicks, potentially giving unintended kick distributions
// 03.28.00 PD - January 28, 2026 - Enhancement:
// - Updated default MullerMandel kick parameters in constants.h to the values from Disberg+2026, previous values were from Kapil+2023
//
//
// Version string format is MM.mm.rr, where
Expand All @@ -1697,7 +1699,7 @@
// if MM is incremented, set mm and rr to 00, even if defect repairs and minor enhancements were also made
// if mm is incremented, set rr to 00, even if defect repairs were also made

const std::string VERSION_STRING = "03.27.03";
const std::string VERSION_STRING = "03.28.00";


# endif // __changelog_h__
6 changes: 3 additions & 3 deletions src/constants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,10 +392,10 @@ constexpr double MULLERMANDEL_SIGMA3 = 0.05;
constexpr double MULLERMANDEL_MUBH = 0.8;
constexpr double MULLERMANDEL_SIGMABH = 0.5;
constexpr double MULLERMANDEL_MINNS = 1.13;
constexpr double MULLERMANDEL_KICKNS = 520.0; // As calibrated by Kapil+ 2023
constexpr double MULLERMANDEL_KICKNS = 630.0; // As calibrated by Disberg+ 2026
constexpr double MULLERMANDEL_KICKBH = 200.0;
constexpr double MULLERMANDEL_SIGMAKICKBH = 0.3;
constexpr double MULLERMANDEL_SIGMAKICKNS = 0.3;
constexpr double MULLERMANDEL_SIGMAKICKBH = 0.45;
constexpr double MULLERMANDEL_SIGMAKICKNS = 0.45;

// Constants for Disberg & Mandel (2025) SN kick prescription
constexpr double DISBERG_MANDEL_MU = 5.60;
Expand Down