Update NirvanaBrewing.java#91
Merged
Merged
Conversation
Wrapped the filter predicate to catch IllegalStateExceptions. Items from mods with unloaded configs get skipped (return false) since they can't be resolved here
Member
|
/spotless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Closes issue #88
Fixes a crash that happens when loading a world with mods that haven't loaded their config at bootstrap, (in my case with Corail Tombstone)
Specifically this fix wraps both isIngredient and hasMix with a try catch so when "IllegalStateException: Cannot get config value before config is loaded" is thrown it skips that config value, this happens because those server config aren't loaded during the PotionBrewing.bootstrap. From what I've seen this doesn't effect the logic at all, which is to be expected and bong recipes are still being generated correctly (like the brain damage bong).
those items that throw the error simply won't get bong recipes generated for them, which is the same outcome as if the other mod wasn't installed, I would make a issue report for corail tombstones but as said in issue 88, their issues are closed at the moment.