Add warning when default random number generator is used#461
Open
thierry-martinez wants to merge 9 commits intoTeamGraphix:masterfrom
Open
Add warning when default random number generator is used#461thierry-martinez wants to merge 9 commits intoTeamGraphix:masterfrom
thierry-martinez wants to merge 9 commits intoTeamGraphix:masterfrom
Conversation
This commit adds a warning when `ensure_rng` is called with `None`. It includes the following fixes: - In `DepolarisingNoiseModel`, the field `rng` has been removed: the current API favors passing `rng` as a method parameter instead of storing it inside the structure. - `rand_dm` and `rand_channel_kraus` now use the `rng` passed as a parameter for the entire computation, instead of relying partially on the default random number generator. - Since TeamGraphix#235 appears not to have been properly fixed, `test_full_reduce_toffoli` is marked as `xfail`.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
=======================================
Coverage 88.85% 88.85%
=======================================
Files 44 44
Lines 6533 6535 +2
=======================================
+ Hits 5805 5807 +2
Misses 728 728 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emlynsg
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a warning when
ensure_rngis called withNone.It includes the following fixes:
In
DepolarisingNoiseModel, the fieldrnghas been removed: the current API favors passingrngas a method parameter instead of storing it inside the structure.rand_dmandrand_channel_krausnow use therngpassed as a parameter for the entire computation, instead of relying partially on the default random number generator.Since [Bug]:
to_pyzx_graph/from_pyzx_graphdon't preserve the semantics when callingpyzx.simplify.full_reduce. #235 appears not to have been properly fixed,test_full_reduce_toffoliis marked asxfail.This PR subsumes #459.