Skip to content

_ - #222

Merged
xtsea merged 1 commit into
mainfrom
dev
Apr 2, 2026
Merged

_#222
xtsea merged 1 commit into
mainfrom
dev

Conversation

@xtsea

@xtsea xtsea commented Apr 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Enhancements:

  • Update the execution runner interface to accept an explicit request_id parameter for calls.

@sourcery-ai

sourcery-ai Bot commented Apr 2, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a required request_id parameter to the execute.run method to make callers supply an explicit request identifier when constructing RequestCall instances.

Class diagram for updated execute.run method

classDiagram
    class Execute {
        +create(options)
        +run(request_id: str, options)
    }
Loading

File-Level Changes

Change Details Files
Make request_id a required, typed parameter for the run method used to construct RequestCall instances.
  • Updated the run method signature to accept request_id: str as a required positional argument before **kw
  • Preserved the existing behavior of passing **kw to RequestCall, implying callers must now also pass request_id explicitly
tgcore/execute/__init__.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The new request_id: str parameter on run is currently unused in the RequestCall construction; consider either wiring it through to the request (e.g., via kw or headers) or omitting it to avoid a misleading, unused argument.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new `request_id: str` parameter on `run` is currently unused in the `RequestCall` construction; consider either wiring it through to the request (e.g., via `kw` or headers) or omitting it to avoid a misleading, unused argument.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@xtsea
xtsea merged commit 3c71c6b into main Apr 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant