[pre-commit.ci] pre-commit autoupdate - #223
Merged
Merged
Conversation
updates: - [github.com/pycqa/isort: 8.0.1 → 9.0.0a3](PyCQA/isort@8.0.1...9.0.0a3)
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the isort pre-commit hook to use the newer 9.0.0a3 release instead of 8.0.1 in the project’s pre-commit configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Since this bumps isort to a 9.0.0 alpha, double-check that your existing isort configuration/options are still supported and that there are no breaking changes in the new major version that affect your repo.
- Consider pinning to a stable isort release rather than an alpha (or documenting why the alpha is needed) to avoid unexpected formatting or behavior changes from pre-release versions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this bumps isort to a 9.0.0 alpha, double-check that your existing isort configuration/options are still supported and that there are no breaking changes in the new major version that affect your repo.
- Consider pinning to a stable isort release rather than an alpha (or documenting why the alpha is needed) to avoid unexpected formatting or behavior changes from pre-release versions.
## Individual Comments
### Comment 1
<location path=".pre-commit-config.yaml" line_range="3" />
<code_context>
repos:
- repo: https://github.com/pycqa/isort
- rev: 8.0.1
+ rev: 9.0.0a3
hooks:
- id: isort
</code_context>
<issue_to_address>
**issue:** Using an alpha isort version in pre-commit may introduce unexpected formatting changes or instability.
Pinning the pre-commit hook to an alpha (`9.0.0a3`) risks unstable or changing behavior as 9.x develops (e.g. shifting formatting rules or regressions). Unless you specifically need a 9.x feature and accept that churn, prefer the latest stable 8.x or wait for a stable 9.x release.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| repos: | ||
| - repo: https://github.com/pycqa/isort | ||
| rev: 8.0.1 | ||
| rev: 9.0.0a3 |
Contributor
There was a problem hiding this comment.
issue: Using an alpha isort version in pre-commit may introduce unexpected formatting changes or instability.
Pinning the pre-commit hook to an alpha (9.0.0a3) risks unstable or changing behavior as 9.x develops (e.g. shifting formatting rules or regressions). Unless you specifically need a 9.x feature and accept that churn, prefer the latest stable 8.x or wait for a stable 9.x release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates:
Summary by Sourcery
Build: